[PATCH] D50200: AMDGPU: Handle "uniform-work-group-size" attribute
Aakanksha Patil via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 14 13:53:43 PST 2018
aakanksha555 added inline comments.
================
Comment at: lib/Target/AMDGPU/AMDGPUAnnotateKernelFeatures.cpp:226-228
+ // FIXME: Needs to account for linkage and visibility of the function.
+ // The most conservative way is to set uniform-work-group-size
+ // attribute as false if the function is visible outside of its module
----------------
arsenm wrote:
> You should just deal with this fixme and add a test for it. This should be as easy as checking Callee->mayBeRedefined?
Did you mean Callee->mayBeDerefined() ?
https://reviews.llvm.org/D50200
More information about the llvm-commits
mailing list