[PATCH] D50200: AMDGPU: Handle "uniform-work-group-size" attribute

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPUAnnotateKernelFeatures.cpp:226-228
+      // FIXME: Needs to account for linkage and visibility of the function.
+      // The most conservative way is to set uniform-work-group-size 
+      // attribute as false if the function is visible outside of its module
----------------
You should just deal with this fixme and add a test for it. This should be as easy as checking Callee->mayBeRedefined?


================
Comment at: lib/Target/AMDGPU/AMDGPUAnnotateKernelFeatures.cpp:253
+      }
+    }
+  }
----------------
It would be cleaner to pull all of this into a function which returns true on changed


https://reviews.llvm.org/D50200