[PATCH] D54419: Preserve MachinePointerInfo offset for unknown base values

[Nikita Popov via Phabricator via llvm-commits]

nikic added a reviewer: bogner.
nikic added a comment.

Not sure who to assign for review, so I added the SelectionDAG code owner.



================
Comment at: test/CodeGen/AArch64/GlobalISel/legalize-extracts.mir:18
     ; CHECK: [[GEP:%[0-9]+]]:_(p0) = G_GEP [[COPY]], [[C]](s64)
-    ; CHECK: [[LOAD1:%[0-9]+]]:_(s64) = G_LOAD [[GEP]](p0) :: (load 8)
+    ; CHECK: [[LOAD1:%[0-9]+]]:_(s64) = G_LOAD [[GEP]](p0) :: (load 8 + 8)
     ; CHECK: [[COPY1:%[0-9]+]]:_(s64) = COPY [[LOAD]](s64)
----------------
The output here looks a bit odd now, usually if there's a base value and offset this will be printed as `load X from XXX + Y`. Maybe I should make it print `load 8 from unknown + 8` here?


================
Comment at: test/CodeGen/X86/byval-odd-size.ll:12
+; CHECK-NEXT:    vmovups 15(%rdi), %xmm0
+; CHECK-NEXT:    vmovups %xmm0, {{[0-9]+}}(%rsp)
+; CHECK-NEXT:    vmovaps (%rdi), %xmm0
----------------
This line used to be `vmovaps %xmm0, 15(%rsp)`.


Repository:
  rL LLVM

https://reviews.llvm.org/D54419