[PATCH] D54314: [ELF] - Fix R_AARCH64_ADR_GOT_PAGE, R_AARCH64_LD64_GOT_LO12 handling against IFUNC symbols.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 12 22:52:40 PST 2018


ruiu added inline comments.


================
Comment at: ELF/InputSection.cpp:608
   case R_GOT:
+  case R_GOT_PLT:
   case R_RELAX_TLS_GD_TO_IE_ABS:
----------------
So, this is not specific to AArch64 and


================
Comment at: ELF/InputSection.cpp:627
   case R_GOT_PAGE_PC:
+  case R_GOT_PAGE_PC_PLT:
   case R_RELAX_TLS_GD_TO_IE_PAGE_PC:
----------------
this is? It seems a bit weird.


https://reviews.llvm.org/D54314





More information about the llvm-commits mailing list