[PATCH] D54314: [ELF] - Fix R_AARCH64_ADR_GOT_PAGE, R_AARCH64_LD64_GOT_LO12 handling against IFUNC symbols.

[Peter Smith via Phabricator via llvm-commits]

peter.smith added a comment.

In https://reviews.llvm.org/D54314#1294189, @grimar wrote:

> In https://reviews.llvm.org/D54314#1293000, @peter.smith wrote:
>
> > I wasn't sure if this was to be applied on top of https://reviews.llvm.org/D54154 or not so I merged the two and ended up with a test failure in  the test modifications done in ELF/gotpc-relax.s for https://reviews.llvm.org/D54154.
>
>
> I merged this one with https://reviews.llvm.org/D54145 today manually and run the test suite. It does not fail for me. 
>  They are fully independent I beleive, so it is what I expected.
>  Here is the merged version I got: F7529563: patch.patch <https://reviews.llvm.org/F7529563>
>
> I think just something went wrong on your side perhaps?


Yes, comparing the diffs, it looks like I missed out adding R_GOT_PC_PLT to needsPlt and needsGot from https://reviews.llvm.org/D54145. With that I get the x86 test passing. Apologies for the noise.


https://reviews.llvm.org/D54314