[PATCH] D54124: [llvm-readelf] Make llvm-readelf more compatible with GNU readelf.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In the description.

`Add --sections-headers as an alias for --sections`: `--section-headers` is now the canonical option name (I still have trouble understanding the plural form though, see my comment above) but `--sections` is an alias.



================
Comment at: tools/llvm-readobj/llvm-readobj.cpp:82
+                               cl::aliasopt(Sections), cl::NotHidden);
+  cl::alias SectionHeadersAlias("section-headers",
+                                cl::desc("Alias for --sections"),
----------------
jhenderson wrote:
> This should be the "main" option, in my opinion, with the other two as aliases. Also, the help text for it should be "Display all section headers." since it doesn't display section contents.
What's your opinion on the plural form `-file-headers`? I think I'm lost why in readelf, `-file-header` is singular while others are plural. Usually there are not more than one program headers, section headers, etc.


Repository:
  rL LLVM

https://reviews.llvm.org/D54124