[PATCH] D54124: [llvm-readelf] Make llvm-readelf more compatible with GNU readelf.

Fri Nov 9 02:02:37 PST 2018

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

Okay, from my point of view, LGTM (with a nit). However, we should probably get some more buy-in on the RFC before breaking people's builds etc, so you might want to hold off on the commit for now.

Any thoughts on how to drum up some more interest?

================
Comment at: test/tools/llvm-readobj/symbols.test:14-15
+RUN: cmp %t.symbols %t.t
+RUN: llvm-readelf -s -elf-output-style LLVM %p/Inputs/trivial.obj.elf-i386 > %t.lowers
+RUN: cmp %t.symbols %t.lowers
+
----------------
Nit: for consistency with the other filenames in this set of cases, maybe use %t.s, if you don't think it's too confusing with assembly?

Repository:
  rL LLVM

https://reviews.llvm.org/D54124