[PATCH] D48797: [CMake] Teach the build system to codesign built products

[Stefan Gränitz via Phabricator via llvm-commits]

sgraenitz added inline comments.


================
Comment at: cmake/modules/AddLLVM.cmake:1603
+    if(NOT CMAKE_CODESIGN)
+      set(CMAKE_CODESIGN xcrun codesign)
+    endif()
----------------
sgraenitz wrote:
> I am way too late with this, but shouldn't it be `set(CMAKE_CODESIGN "xcrun codesign")` to avoid getting a list "xcrun;codesign"?
Oh ok, the implementation is correct. Getting a list seems to be the preferable behaviour here. (https://stackoverflow.com/questions/8925396)


https://reviews.llvm.org/D48797