[PATCH] D48797: [CMake] Teach the build system to codesign built products

Stefan Gränitz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 8 03:49:12 PST 2018


sgraenitz added inline comments.


================
Comment at: cmake/modules/AddLLVM.cmake:1603
+    if(NOT CMAKE_CODESIGN)
+      set(CMAKE_CODESIGN xcrun codesign)
+    endif()
----------------
I am way too late with this, but shouldn't it be `set(CMAKE_CODESIGN "xcrun codesign")` to avoid getting a list "xcrun;codesign"?


https://reviews.llvm.org/D48797





More information about the llvm-commits mailing list