[PATCH] D54232: [sancov] Put .SCOV* sections into the right comdat groups on COFF

Matt Morehouse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 7 16:07:01 PST 2018


morehouse added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/Instrumentation.cpp:82
+  // Make a unique comdat name for internal linkage things on ELF.
+  if (T.isOSBinFormatELF() && F.hasLocalLinkage()) {
     if (ModuleId.empty())
----------------
Does COFF not have comdat naming collisions for local symbols like ELF does?


https://reviews.llvm.org/D54232





More information about the llvm-commits mailing list