[PATCH] D54232: [sancov] Put .SCOV* sections into the right comdat groups on COFF
Reid Kleckner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 7 14:43:38 PST 2018
rnk created this revision.
rnk added reviewers: metzman, hans, morehouse.
Herald added a subscriber: hiraditya.
Avoids linker errors about relocations against discarded sections.
This was uncovered during the clang roll here:
https://chromium-review.googlesource.com/c/chromium/src/+/1321863#message-717516acfcf829176f6a2f50980f7a4bdd66469a
After this change, libGLESv2 links successfully for me.
https://reviews.llvm.org/D54232
Files:
llvm/include/llvm/Transforms/Instrumentation.h
llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp
llvm/lib/Transforms/Instrumentation/Instrumentation.cpp
llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp
llvm/test/Instrumentation/SanitizerCoverage/coff-comdat.ll
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54232.173037.patch
Type: text/x-patch
Size: 6986 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181107/0ffc7a04/attachment.bin>
More information about the llvm-commits
mailing list