[PATCH] D54191: [llvm-rc] Support joined or separate spelling for /fo flag

[Petr Hosek via Phabricator via llvm-commits]

phosek updated this revision to Diff 173045.
phosek added a comment.

Test added, I'd be fine adding tests for more flags in subsequent changes.


Repository:
  rL LLVM

https://reviews.llvm.org/D54191

Files:
  llvm/test/tools/llvm-rc/Inputs/empty.rc
  llvm/test/tools/llvm-rc/flags.test
  llvm/tools/llvm-rc/Opts.td


Index: llvm/tools/llvm-rc/Opts.td
===================================================================
--- llvm/tools/llvm-rc/Opts.td
+++ llvm/tools/llvm-rc/Opts.td
@@ -4,7 +4,7 @@
 // These options seem to be important for the tool
 // and should be implemented.
 
-def FILEOUT : Separate<[ "/", "-" ], "FO">,
+def FILEOUT : JoinedOrSeparate<[ "/", "-" ], "FO">,
               HelpText<"Change the output file location.">;
 
 def DEFINE : Separate<[ "/", "-" ], "D">,
Index: llvm/test/tools/llvm-rc/flags.test
===================================================================
--- /dev/null
+++ llvm/test/tools/llvm-rc/flags.test
@@ -0,0 +1,4 @@
+; RUN: llvm-rc /dry-run /FO %t %p/Inputs/empty.rc 2>&1 | FileCheck %s --allow-empty --check-prefix=FO
+; RUN: llvm-rc /dry-run /FO%t %p/Inputs/empty.rc 2>&1 | FileCheck %s --allow-empty --check-prefix=FO
+
+; FO-NOT: Exactly one input file should be provided.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54191.173045.patch
Type: text/x-patch
Size: 909 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181107/76482ee7/attachment.bin>