[PATCH] D54191: [llvm-rc] Support joined or separate spelling for /fo flag

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 6 23:43:40 PST 2018


mstorsjo added a comment.

Could you add a test for this? (I guess it's easiest to change one of the existing tests to use a different syntax in one place.)

Also, this isn't the only option that can be `JoinedOrSeparate`, with a quick test it seems like this goes for at least `CODEPAGE` and `DEFINE`  as well, probably for all of them. But I won't demand fixing all of them at once, as they're tangential to what you need, and many of them aren't really implemented in llvm-rc yet.


Repository:
  rL LLVM

https://reviews.llvm.org/D54191





More information about the llvm-commits mailing list