[PATCH] D54220: [llvm-readobj] Implement LLVM style printer for --notes

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: tools/llvm-readobj/ELFDumper.cpp:3668
     if (DataSize == sizeof(typename ELFT::uint))
-      OS << format("0x%llx\n",
+      OS << format("0x%llx",
                    (uint64_t)(*(const typename ELFT::Addr *)Data.data()));
----------------
How about `#include "llvm/Support/FormatVariadic.h"`

`formatv("0x{0:x}", *(const typename ELFT::Addr *)Data.data())`

On LP64 Linux `uint64_t` should (best) use `%lx`


Repository:
  rL LLVM

https://reviews.llvm.org/D54220