[PATCH] D54220: [llvm-readobj] Implement LLVM style printer for --notes

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: tools/llvm-readobj/ELFDumper.cpp:4534
+      W.printString("Type", getGNUNoteTypeName(Type));
+      printGNUNoteLLVMStyle<ELFT>(Type, Descriptor, Descriptor.size(), W);
+    } else if (Name == "FreeBSD") {
----------------
`Descriptor.size()` is unnecessary.

`printGNUNoteLLVMStyle<ELFT>(Type, Descriptor, W);` The function signature can be changed accordingly.


================
Comment at: tools/llvm-readobj/ELFDumper.cpp:4540
+      const AMDGPUNote N =
+          getAMDGPUNote<ELFT>(Type, Descriptor, Descriptor.size());
+      if (!N.type.empty())
----------------
ditto


Repository:
  rL LLVM

https://reviews.llvm.org/D54220