[PATCH] D54179: [llvm-mca] Move the AssembleInput logic into its own class.

Andrea Di Biagio via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 7 10:36:48 PST 2018


andreadb accepted this revision.
andreadb added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: tools/llvm-mca/CodeRegionGenerator.cpp:34
+// A comment consumer that parses strings.  The only valid tokens are strings.
+class MCACommentConsumer : public AsmCommentConsumer {
+public:
----------------
you can probably make this class final too.


https://reviews.llvm.org/D54179





More information about the llvm-commits mailing list