[PATCH] D54179: [llvm-mca] Move the AssembleInput logic into its own class.

Matt Davis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 7 10:13:23 PST 2018


mattd updated this revision to Diff 172979.
mattd added a comment.

Thanks for the reviews.  I've updated the patch per the feedback given.

- Removed unnecessary header.
- Fixed the header comment to be clearer in CodeRegionGenerators.{h,cpp}.
- Created header and implementation files to describe the CodeRegionGenerators.  The AsmCodeRegionGenerator lives in these now.
- Added an anchor and virtual dtor to CodeRegionGenerators.
- Moved the helper class from AsmCodeRegionGenerators into CodeRegionGenerators.cpp, and cleaned up the includes accordingly.


https://reviews.llvm.org/D54179

Files:
  tools/llvm-mca/CMakeLists.txt
  tools/llvm-mca/CodeRegion.h
  tools/llvm-mca/CodeRegionGenerator.cpp
  tools/llvm-mca/CodeRegionGenerator.h
  tools/llvm-mca/llvm-mca.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54179.172979.patch
Type: text/x-patch
Size: 14437 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181107/449ece3b/attachment-0001.bin>


More information about the llvm-commits mailing list