[PATCH] D52010: RegAllocFast: Rewrite and improve
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 6 15:10:06 PST 2018
arsenm added a comment.
In https://reviews.llvm.org/D52010#1289522, @MatzeB wrote:
> > It seems to have a bug now where the first time a physical register is used, it immediately sets kill on it even though there are further uses of the same def
>
> You mean for a pre-assigned physreg that looks something like this:
> bb.0:
>
> use $somereg ...
>
> ...
>
> use $somereg ...
>
>
> we add a kill flag on the first use? Will see if I figure this out, I'm surprised this didn't hit me in unittests then...
Yes. It might have specifically been when it was a live-in. I don't see it with this patch, so I didn't spend too much time trying to understand why
Repository:
rL LLVM
https://reviews.llvm.org/D52010
More information about the llvm-commits
mailing list