[PATCH] D54153: Fix compilation issue in VS2017 with Clang-tablegen and LLVM-tablegen

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle added a comment.

In https://reviews.llvm.org/D54153#1288936, @rnk wrote:

> In https://reviews.llvm.org/D54153#1288824, @aganea wrote:
>
> > The issue is that XXX-tablegen-host .vcxprojects are explicitly calling `cmake --build`, thus not going through MSBuild's dependency graph. It looks like the Ninja generator doesn't do that.
>
>
> Really? I thought it did... The main reason I don't use the "optimized tablegen" build configuration is because it doesn't keep everything in a single ninja build file. I just always compile with optimization, asserts, and debug info enabled.


That's right. I just double-checked, and in my debug build setup I do have separate "build.ninja" files which I don't have for my optimized build. So while I'm no expert in LLVM's build system, it does like this change shouldn't be gated by the generator type.


Repository:
  rL LLVM

https://reviews.llvm.org/D54153