[PATCH] D54153: Fix compilation issue in VS2017 with Clang-tablegen and LLVM-tablegen

Tue Nov 6 10:06:35 PST 2018

rnk added a comment.

In https://reviews.llvm.org/D54153#1288824, @aganea wrote:

> The issue is that XXX-tablegen-host .vcxprojects are explicitly calling `cmake --build`, thus not going through MSBuild's dependency graph. It looks like the Ninja generator doesn't do that.

Really? I thought it did... The main reason I don't use the "optimized tablegen" build configuration is because it doesn't keep everything in a single ninja build file. I just always compile with optimization, asserts, and debug info enabled.

> I can make this hack specific to the "Visual Studios" generators.

It seems like it would be a problem in all generators to me. It's just that MSBuild is the only one with a locking mechanism that detects this race.

Repository:
  rL LLVM

https://reviews.llvm.org/D54153