[PATCH] D53840: Preprocessing support in tablegen

[Vyacheslav Zakharin via Phabricator via llvm-commits]

vzakhari added inline comments.


================
Comment at: lib/TableGen/TGLexer.cpp:605-608
+void TGLexer::prepNewPreprocessorControl() {
+  PreprocessorControl =
+      make_unique<std::vector<PreprocessorControlDesc> >();
+}
----------------
nhaehnle wrote:
> nhaehnle wrote:
> > Please just inline this function where it's used. Having to jump here increases the cognitive overhead of reading the code.
> What about this one?
Oh, your previous comment referred to prepNewPreprocessorControl(), and I inlined it into prepEnterInclude().  I wanted to keep prepEnterInclude() to have a complete pair of enter/exit include method, but probably it would better be inlined.  I will do it shortly.


Repository:
  rL LLVM

https://reviews.llvm.org/D53840