[PATCH] D53840: Preprocessing support in tablegen

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle added a comment.

Thanks for making those changes. The EOF handling does look better.



================
Comment at: docs/TableGen/LangRef.rst:455
+
+TableGen's embedded preprocessor supports the following directives:
+
----------------
Could you please add something along the lines of: "TableGen's embedded preprocessor is only intended for conditional compilation. It supports the following directives:"


================
Comment at: lib/TableGen/TGLexer.cpp:605-608
+void TGLexer::prepNewPreprocessorControl() {
+  PreprocessorControl =
+      make_unique<std::vector<PreprocessorControlDesc> >();
+}
----------------
nhaehnle wrote:
> Please just inline this function where it's used. Having to jump here increases the cognitive overhead of reading the code.
What about this one?


Repository:
  rL LLVM

https://reviews.llvm.org/D53840