[PATCH] D54108: [ARM] Enable mixed types in ARM CGP

[Sam Parker via Phabricator via llvm-commits]

samparker added inline comments.


================
Comment at: lib/Target/ARM/ARMCodeGenPrepare.cpp:239
   else if (auto *Trunc = dyn_cast<TruncInst>(V))
-    return isSupportedType(Trunc);
+    return GreaterOrEqualTypeSize(Trunc->getOperand(0));
   return false;
----------------
SjoerdMeijer wrote:
> I don't really understand the 'Equal' part in the GreaterOrEqual comparison. Can these types be equal, and is that what we want? 
Good question, looks like I've messed up there.


================
Comment at: lib/Target/ARM/ARMCodeGenPrepare.cpp:251
 
   if (auto *Store = dyn_cast<StoreInst>(V))
+    return LessOrEqualTypeSize(Store->getValueOperand());
----------------
SjoerdMeijer wrote:
> By briefly looking at these new cases here and the tests, I think we are missing some tests.
Agreed.


https://reviews.llvm.org/D54108