[PATCH] D54108: [ARM] Enable mixed types in ARM CGP
Sjoerd Meijer via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 6 01:32:24 PST 2018
SjoerdMeijer added inline comments.
================
Comment at: lib/Target/ARM/ARMCodeGenPrepare.cpp:239
else if (auto *Trunc = dyn_cast<TruncInst>(V))
- return isSupportedType(Trunc);
+ return GreaterOrEqualTypeSize(Trunc->getOperand(0));
return false;
----------------
I don't really understand the 'Equal' part in the GreaterOrEqual comparison. Can these types be equal, and is that what we want?
================
Comment at: lib/Target/ARM/ARMCodeGenPrepare.cpp:251
if (auto *Store = dyn_cast<StoreInst>(V))
+ return LessOrEqualTypeSize(Store->getValueOperand());
----------------
By briefly looking at these new cases here and the tests, I think we are missing some tests.
https://reviews.llvm.org/D54108
More information about the llvm-commits
mailing list