[PATCH] D53222: AMDGPU: Add sram-ecc feature

Konstantin Zhuravlyov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 5 10:59:22 PST 2018


kzhuravl added a comment.

In https://reviews.llvm.org/D53222#1287489, @t-tye wrote:

> Does the assembler need any support for this? For example, does the .amdgcn_target directive need to accept the +sramecc and ensure the e_flag is set accordingly?


This is already done and tests added. In particular: test/CodeGen/AMDGPU/directive-amdgcn-target.ll

> Does scheduler need to check the setting for the instruction latency for 3 operand ALU that involve sub dword operands s a separate patch?

This deserves/will be in separate change.


https://reviews.llvm.org/D53222





More information about the llvm-commits mailing list