[PATCH] D53345: [ThinLTO] Split NotEligibleToImport into legality and inlinability flags

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added inline comments.


================
Comment at: lib/Analysis/ModuleSummaryAnalysis.cpp:362
+      // FIXME: refactor this to use the same code that inliner is using.
+      F.isVarArg() ||
+          // Don't try to import functions with noinline attribute.
----------------
davidxl wrote:
> How much overhead does it incur if isVarArg check is removed? Having a check here prevent cross module inlining from happening even when inliner is enhanced in the future (which will incur effort to diagnose the problem).
In fact, I am planning a follow-on change to modify this, because the inliner has since been changed and some varargs are now inlineable. But I wanted to do that in a follow-on patch, to keep this one just about the refactoring of the flag, without any end-behavior change.


Repository:
  rL LLVM

https://reviews.llvm.org/D53345