[PATCH] D53345: [ThinLTO] Split NotEligibleToImport into legality and inlinability flags

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: lib/Analysis/ModuleSummaryAnalysis.cpp:362
+      // FIXME: refactor this to use the same code that inliner is using.
+      F.isVarArg() ||
+          // Don't try to import functions with noinline attribute.
----------------
How much overhead does it incur if isVarArg check is removed? Having a check here prevent cross module inlining from happening even when inliner is enhanced in the future (which will incur effort to diagnose the problem).


Repository:
  rL LLVM

https://reviews.llvm.org/D53345