[PATCH] D53762: AMDGPU: Combine DPP mov with use instuctions (VOP1/2/3)
Stanislav Mekhanoshin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Nov 2 09:54:57 PDT 2018
rampitec added a comment.
You do not need a special pseudo for opsel, just use VOP3 and immediate value for modifier. This is much like you did above for omod.
================
Comment at: lib/Target/AMDGPU/GCNDPPCombine.cpp:350
+ // check if other than abs|neg modifiers are set (opsel for example)
+ const int64_t Mask = ~(SISrcMods::ABS | SISrcMods::NEG);
+ if (!hasNoImmOrEqual(OrigMI, AMDGPU::OpName::src0_modifiers, 0, Mask) ||
----------------
AFAIR proper default value for opsel has 1 bit set (which means use high bits for high part).
Repository:
rL LLVM
https://reviews.llvm.org/D53762
More information about the llvm-commits
mailing list