[PATCH] D53985: Use C++11 fallthrough attribute syntax when available and add a break

[Richard Smith - zygoloid via Phabricator via llvm-commits]

rsmith added a comment.

In https://reviews.llvm.org/D53985#1284282, @aaron.ballman wrote:

> In https://reviews.llvm.org/D53985#1284246, @rnk wrote:
>
> > In https://reviews.llvm.org/D53985#1284196, @ldionne wrote:
> >
> > > Would it make sense to add the GNU spelling to the attribute in Clang?
> >
> >
> > I'll redirect that question to @rsmith and @aaron.ballman. I have a vague recollection that it was considered and rejected, but that decision may have predated GCC 7.
>
>
> I'm not opposed to it given that it's an attribute supported by GCC.


Likewise; I think we decided not to do this before because (a) GCC didn't have such an attribute, and (b) it wasn't clear that we wanted to support "attribute statements" for GNU attributes at all, or whether this should be an attribute appertaining to the label.


Repository:
  rL LLVM

https://reviews.llvm.org/D53985