[PATCH] D53877: [IR] Strawman for dedicated FNeg IR instruction

[Cameron McInally via Phabricator via llvm-commits]

cameron.mcinally added inline comments.


================
Comment at: include/llvm-c/Core.h:64
   LLVMInvoke         = 5,
   /* removed 6 due to API changes */
   LLVMUnreachable    = 7,
----------------
jyknight wrote:
> lebedev.ri wrote:
> > This strongly suggests that you can not reorder/renumber the existing enumerators.
> You should _NOT_ renumber the existing constants in the llvm-c/* APIs. External users are depending on them being stable.
> 
> (Adding a comment indicating that while you're in here would be good).
That settles it! Thanks, James.

So LLVMAddrSpaceCast is grouped correctly, but the value is out of order. Is that the correct way to add a new member?

Or should I just add FNeg to the end of the list?


Repository:
  rL LLVM

https://reviews.llvm.org/D53877