[PATCH] D53877: [IR] Strawman for dedicated FNeg IR instruction

James Y Knight via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 1 11:26:23 PDT 2018


jyknight added inline comments.


================
Comment at: include/llvm-c/Core.h:64
   LLVMInvoke         = 5,
   /* removed 6 due to API changes */
   LLVMUnreachable    = 7,
----------------
lebedev.ri wrote:
> This strongly suggests that you can not reorder/renumber the existing enumerators.
You should _NOT_ renumber the existing constants in the llvm-c/* APIs. External users are depending on them being stable.

(Adding a comment indicating that while you're in here would be good).


Repository:
  rL LLVM

https://reviews.llvm.org/D53877





More information about the llvm-commits mailing list