[PATCH] D53877: [IR] Strawman for dedicated FNeg IR instruction
Cameron McInally via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 1 08:15:00 PDT 2018
cameron.mcinally added inline comments.
================
Comment at: include/llvm-c/Core.h:111
+ LLVMBitCast = 42,
+ LLVMAddrSpaceCast = 61,
----------------
arsenm wrote:
> If you're renumbering all of these anyway, might as well fix AddrSpaceCast to be consecutive?
Ah, forgot about these. Are we all in agreement that it's safe to reorder these values? I don't fully understand the library interactions, so I'm not sure.
I'll go ahead and implement your suggestion. If it turns out it's not safe, I'll revert the change later.
Repository:
rL LLVM
https://reviews.llvm.org/D53877
More information about the llvm-commits
mailing list