[PATCH] D53877: [IR] Strawman for dedicated FNeg IR instruction

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: include/llvm-c/Core.h:111
+  LLVMBitCast        = 42,
+  LLVMAddrSpaceCast  = 61,
 
----------------
If you're renumbering all of these anyway, might as well fix AddrSpaceCast to be consecutive?


================
Comment at: lib/AsmParser/LLParser.cpp:6122-6123
+    break;
+  case 1: Valid = LHS->getType()->isIntOrIntVectorTy(); break;
+  case 2: Valid = LHS->getType()->isFPOrFPVectorTy(); break;
+  }
----------------
Put these on separate lines?


================
Comment at: test/Assembler/fast-math-flags.ll:81
+  %f = fneg nnan  float %x
+; CHECK:  %f_vec = fneg nnan  <3 x float> %vec
+  %f_vec = fneg nnan  <3 x float> %vec
----------------
Looks like extra whitespace in the test and output (I would hope this test would use -strict-whitespace, but it looks like this is an issue with the rest of the tests here as well)


Repository:
  rL LLVM

https://reviews.llvm.org/D53877