[llvm] r345789 - [InlineCost] Remove a dead constant; NFC

[George Burgess IV via llvm-commits]

(highlighting for chandler in case I missed something and we should be
using this constant somewhere)

On Wed, Oct 31, 2018 at 3:47 PM George Burgess IV via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: gbiv
> Date: Wed Oct 31 15:45:31 2018
> New Revision: 345789
>
> URL: http://llvm.org/viewvc/llvm-project?rev=345789&view=rev
> Log:
> [InlineCost] Remove a dead constant; NFC
>
> My `grep`-fu indicates that this hasn't been used for years. It also no
> longer makes much sense to have this flavor of penalty in general, since
> a call to a noreturn should mean that we're in a BB that's terminated by
> `unreachable`. That case is accounted for by
> CallAnalyzer::allowSizeGrowth.
>
> Modified:
>     llvm/trunk/include/llvm/Analysis/InlineCost.h
>
> Modified: llvm/trunk/include/llvm/Analysis/InlineCost.h
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Analysis/InlineCost.h?rev=345789&r1=345788&r2=345789&view=diff
>
> ==============================================================================
> --- llvm/trunk/include/llvm/Analysis/InlineCost.h (original)
> +++ llvm/trunk/include/llvm/Analysis/InlineCost.h Wed Oct 31 15:45:31 2018
> @@ -46,7 +46,6 @@ const int IndirectCallThreshold = 100;
>  const int CallPenalty = 25;
>  const int LastCallToStaticBonus = 15000;
>  const int ColdccPenalty = 2000;
> -const int NoreturnPenalty = 10000;
>  /// Do not inline functions which allocate this many bytes on the stack
>  /// when the caller is recursive.
>  const unsigned TotalAllocaSizeRecursiveCaller = 1024;
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181031/1e6dcf67/attachment.html>