<div dir="ltr">(highlighting for chandler in case I missed something and we should be using this constant somewhere)</div><br><div class="gmail_quote"><div dir="ltr">On Wed, Oct 31, 2018 at 3:47 PM George Burgess IV via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: gbiv<br>
Date: Wed Oct 31 15:45:31 2018<br>
New Revision: 345789<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=345789&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=345789&view=rev</a><br>
Log:<br>
[InlineCost] Remove a dead constant; NFC<br>
<br>
My `grep`-fu indicates that this hasn't been used for years. It also no<br>
longer makes much sense to have this flavor of penalty in general, since<br>
a call to a noreturn should mean that we're in a BB that's terminated by<br>
`unreachable`. That case is accounted for by<br>
CallAnalyzer::allowSizeGrowth.<br>
<br>
Modified:<br>
    llvm/trunk/include/llvm/Analysis/InlineCost.h<br>
<br>
Modified: llvm/trunk/include/llvm/Analysis/InlineCost.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Analysis/InlineCost.h?rev=345789&r1=345788&r2=345789&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Analysis/InlineCost.h?rev=345789&r1=345788&r2=345789&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/include/llvm/Analysis/InlineCost.h (original)<br>
+++ llvm/trunk/include/llvm/Analysis/InlineCost.h Wed Oct 31 15:45:31 2018<br>
@@ -46,7 +46,6 @@ const int IndirectCallThreshold = 100;<br>
 const int CallPenalty = 25;<br>
 const int LastCallToStaticBonus = 15000;<br>
 const int ColdccPenalty = 2000;<br>
-const int NoreturnPenalty = 10000;<br>
 /// Do not inline functions which allocate this many bytes on the stack<br>
 /// when the caller is recursive.<br>
 const unsigned TotalAllocaSizeRecursiveCaller = 1024;<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>