[PATCH] D53189: [SCEV][NFC] Avoid redundant computations when doing AddRec merge

[Roman Tereshin via Phabricator via llvm-commits]

rtereshin accepted this revision.
rtereshin added a comment.
This revision is now accepted and ready to land.

Do you think it's better to remove the NFC tag from the patch? It doesn't look like it's completely NFC, though, I've tested this out for a major (though, out of tree) GPU target on a very large suite of shaders and found no difference.

What's the compile time impact roughly?

I also think that giving the wrapping flags a thought here (in a sense of preserving / re-deriving them a bit better) is valuable, but I don't have any concrete suggestions unfortunately.

Regardless, LGTM, thanks for doing this.


https://reviews.llvm.org/D53189