[PATCH] D53945: [TextAPI] TBD Reader/Writer

[Duncan P. N. Exon Smith via Phabricator via llvm-commits]

dexonsmith added inline comments.


================
Comment at: llvm/lib/TextAPI/TextStub.cpp:337-338
+        std::sort(Section.Symbols.begin(), Section.Symbols.end());
+        std::sort(Section.Classes.begin(), Section.Classes.begin());
+        std::sort(Section.ClassEHs.begin(), Section.ClassEHs.begin());
+        std::sort(Section.IVars.begin(), Section.IVars.end());
----------------
Related to @mgrang's comment about using range-based `llvm::sort`: it looks like there's a bug here where nothing gets sorted, since `begin` is passed twice.


Repository:
  rL LLVM

https://reviews.llvm.org/D53945