[PATCH] D53945: [TextAPI] TBD Reader/Writer

Mandeep Singh Grang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 31 12:00:20 PDT 2018


mgrang added inline comments.


================
Comment at: llvm/lib/TextAPI/TextStub.cpp:336
+        }
+        std::sort(Section.Symbols.begin(), Section.Symbols.end());
+        std::sort(Section.Classes.begin(), Section.Classes.begin());
----------------
Please use range based llvm::sort(Section.Symbols), etc instead of std::sort.

See https://llvm.org/docs/CodingStandards.html#beware-of-non-deterministic-sorting-order-of-equal-elements


Repository:
  rL LLVM

https://reviews.llvm.org/D53945





More information about the llvm-commits mailing list