[PATCH] D53887: [HotColdSplitting] [WIP] Outline more than once per function

[Vedant Kumar via Phabricator via llvm-commits]

vsk added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/HotColdSplitting.cpp:348
+      // function must be cold.
+      if (pred_empty(&PredBB)) {
+        ColdRegion.EntireFunctionCold = true;
----------------
hiraditya wrote:
> I think, this can go before the previous check.
I think that would cause splitting to fail when a predecessor outside of the cold region is the entry block. Am I missing something?


================
Comment at: llvm/lib/Transforms/IPO/HotColdSplitting.cpp:489
+
+    if (Region.isEntireFunctionCold()) {
+      // TODO: Move this function into a cold section.
----------------
hiraditya wrote:
> Add optimize for size attribute?
Good point.


https://reviews.llvm.org/D53887