[PATCH] D53887: [HotColdSplitting] [WIP] Outline more than once per function

[Aditya Kumar via Phabricator via llvm-commits]

hiraditya added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/HotColdSplitting.cpp:348
+      // function must be cold.
+      if (pred_empty(&PredBB)) {
+        ColdRegion.EntireFunctionCold = true;
----------------
I think, this can go before the previous check.


================
Comment at: llvm/lib/Transforms/IPO/HotColdSplitting.cpp:489
+
+    if (Region.isEntireFunctionCold()) {
+      // TODO: Move this function into a cold section.
----------------
Add optimize for size attribute?


https://reviews.llvm.org/D53887