[PATCH] D53786: [AliasSetTracker] Actually delete instructions from the AliasSetTracker.

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 29 22:36:56 PDT 2018


mkazantsev added a comment.

Is it possible to write a test on that?



================
Comment at: lib/Analysis/AliasSetTracker.cpp:554
 
+void AliasSetTracker::deleteValue(Instruction *I) {
+  auto Loc = MemoryLocation::getOrNone(I);
----------------
Does it make sense to name it `deleteInstruction` and remove the cast below?


Repository:
  rL LLVM

https://reviews.llvm.org/D53786





More information about the llvm-commits mailing list