[PATCH] D53786: [AliasSetTracker] Actually delete instructions from the AliasSetTracker.

[Alina Sbirlea via Phabricator via llvm-commits]

asbirlea added inline comments.


================
Comment at: lib/Analysis/AliasSetTracker.cpp:555
+void AliasSetTracker::deleteValue(Instruction *I) {
+  auto Loc = MemoryLocation::getOrNone(I);
+  if (Loc == None)
----------------
reames wrote:
> I get what you're going for, but this is not enough.  Some instructions (calls) can map to multiple memory locations.  You're also not removing unknown instructions.  
You're right about the unknown instructions. I had thought that at least we're removing those, but they're never added to the PointerMap.
So, yeah, I don't understand the purpose of deleteValue() at all.
AFAICT, all these calls and the API can be dropped.


Repository:
  rL LLVM

https://reviews.llvm.org/D53786