[PATCH] D53733: [llvm-objcopy] Fix --keep-global-symbol/--globalize-symbol for undefined symbols.

Jordan Rupprecht via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 29 11:07:22 PDT 2018


rupprecht added inline comments.


================
Comment at: test/tools/llvm-objcopy/globalize-undefined-sym.test:11
+
+# RUN: llvm-objcopy --keep-global-symbol Foo %t.o %t.3.o
+# RUN: llvm-readobj -symbols %t.3.o | FileCheck %s
----------------
jhenderson wrote:
> Are  you sure this is Foo? That's a symbol that doesn't even exist. I assume you meant it to be Weak or Global?
Foo is intentional, sorry for not explaining in a test comment why -- fixed.


Repository:
  rL LLVM

https://reviews.llvm.org/D53733





More information about the llvm-commits mailing list