[PATCH] D53733: [llvm-objcopy] Fix --keep-global-symbol/--globalize-symbol for undefined symbols.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

My feeling is that a single separate test is not the right way to test this. I think it makes more sense for an undefined symbol to be added to globalize.test and --keep-global-symbols.test. What do you think?



================
Comment at: test/tools/llvm-objcopy/globalize-undefined-sym.test:11
+
+# RUN: llvm-objcopy --keep-global-symbol Foo %t.o %t.3.o
+# RUN: llvm-readobj -symbols %t.3.o | FileCheck %s
----------------
Are  you sure this is Foo? That's a symbol that doesn't even exist. I assume you meant it to be Weak or Global?


Repository:
  rL LLVM

https://reviews.llvm.org/D53733