[PATCH] D49672: [CMake] Honor LLVM_EXTERNAL_<proj>_SOURCE_DIR

[David Greene via Phabricator via llvm-commits]

greened added a comment.

In https://reviews.llvm.org/D49672#1271673, @beanz wrote:

> All you should need to do is add `CACHE STRING ""` to the `set` command in line 137.


Ok.  I'm not well-versed in the incantations of cmake.  At the very least it seems like doing this would require a big fat comment explaining what is going on.  Is that better than saying it directly in the code via conditionals?  I don't know and will defer to the people who maintain the build system.


Repository:
  rL LLVM

https://reviews.llvm.org/D49672