[PATCH] D49672: [CMake] Honor LLVM_EXTERNAL_<proj>_SOURCE_DIR

Chris Bieneman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 22 16:54:24 PDT 2018


beanz added a comment.

I don't disagree with the intent of the patch, but this patch is *way* more complicated than it needs to be to accomplish the goal. All you should need to do is add `CACHE STRING ""` to the `set` command in line 137. The set command's `CACHE` option doesn't override existing values, it only sets them if they were not previously set.


Repository:
  rL LLVM

https://reviews.llvm.org/D49672





More information about the llvm-commits mailing list