[PATCH] D53649: [TargetLowering] Improve vXi64 UITOFP vXf64 support (P38226)

Thu Oct 25 04:03:09 PDT 2018

RKSimon added a comment.

In https://reviews.llvm.org/D53649#1275352, @craig.topper wrote:

> LGTM
>
> Not sure I understood the AVX512F comment about vcvtusi2sdq not being legal. Isn't it allowed with AVX512F in X86TargetLowering::LowerUINT_TO_FP? It can't be explicitly marked Legal with setOperationAction because that interface only mentions the input type and we still have to checkout the output type.

Thanks - you're right, unless we add more annoying _Int patterns I don't see a way around it.

================
Comment at: include/llvm/CodeGen/TargetLowering.h:3659
+  /// \returns True, if the expansion was successful, false otherwise
+  bool expandUINT_TO_FP(SDNode *N, SDValue &Result, SelectionDAG &DAG) const;
+
----------------
craig.topper wrote:
> Might want to include the types in the function name?
I'm intending to move other ui2fp expansions over as well, so I'll keep these general.

Repository:
  rL LLVM

https://reviews.llvm.org/D53649