[PATCH] D53649: [TargetLowering] Improve vXi64 UITOFP vXf64 support (P38226)

[Craig Topper via Phabricator via llvm-commits]

craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.

LGTM

Not sure I understood the AVX512F comment about vcvtusi2sdq not being legal. Isn't it allowed with AVX512F in X86TargetLowering::LowerUINT_TO_FP? It can't be explicitly marked Legal with setOperationAction because that interface only mentions the input type and we still have to checkout the output type.**bold text**



================
Comment at: include/llvm/CodeGen/TargetLowering.h:3659
+  /// \returns True, if the expansion was successful, false otherwise
+  bool expandUINT_TO_FP(SDNode *N, SDValue &Result, SelectionDAG &DAG) const;
+
----------------
Might want to include the types in the function name?


Repository:
  rL LLVM

https://reviews.llvm.org/D53649