[PATCH] D53650: [FPEnv] Last BinaryOperator::isFNeg(...) to m_FNeg(...) changes
Sanjay Patel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 24 15:47:30 PDT 2018
spatel added a comment.
Nice - that wasn't as bad as I was fearing. :)
I'm not sure how to expose a test diff with the fast-isel change (some combine appears to already be undef aware), but here's an instcombine test:
https://reviews.llvm.org/rL345206
================
Comment at: lib/CodeGen/SelectionDAG/FastISel.cpp:1697
bool FastISel::selectFNeg(const User *I) {
unsigned OpReg = getRegForValue(BinaryOperator::getFNegArgument(I));
if (!OpReg)
----------------
Use match() here, so we can get rid of getFNegArgument() too?
Repository:
rL LLVM
https://reviews.llvm.org/D53650
More information about the llvm-commits
mailing list