[PATCH] D53650: [FPEnv] Last BinaryOperator::isFNeg(...) to m_FNeg(...) changes

Cameron McInally via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 24 08:42:50 PDT 2018


cameron.mcinally created this revision.
cameron.mcinally added a reviewer: spatel.
Herald added a subscriber: llvm-commits.

Continuing work from https://reviews.llvm.org/D52934 and https://reviews.llvm.org/D53205...

These are the last two BinaryOperator::isFNeg(...) references. Replace them with m_FNeg(...) to avoid regressions when we separate FNeg from the FSub IR instruction.


Repository:
  rL LLVM

https://reviews.llvm.org/D53650

Files:
  lib/CodeGen/SelectionDAG/FastISel.cpp
  lib/Transforms/InstCombine/InstCombineCasts.cpp


Index: lib/Transforms/InstCombine/InstCombineCasts.cpp
===================================================================
--- lib/Transforms/InstCombine/InstCombineCasts.cpp
+++ lib/Transforms/InstCombine/InstCombineCasts.cpp
@@ -1612,8 +1612,9 @@
     }
 
     // (fptrunc (fneg x)) -> (fneg (fptrunc x))
-    if (BinaryOperator::isFNeg(OpI)) {
-      Value *InnerTrunc = Builder.CreateFPTrunc(OpI->getOperand(1), Ty);
+    Value *X;
+    if (match(OpI, m_FNeg(m_Value(X)))) {
+      Value *InnerTrunc = Builder.CreateFPTrunc(X, Ty);
       return BinaryOperator::CreateFNegFMF(InnerTrunc, OpI);
     }
   }
Index: lib/CodeGen/SelectionDAG/FastISel.cpp
===================================================================
--- lib/CodeGen/SelectionDAG/FastISel.cpp
+++ lib/CodeGen/SelectionDAG/FastISel.cpp
@@ -89,6 +89,7 @@
 #include "llvm/IR/Mangler.h"
 #include "llvm/IR/Metadata.h"
 #include "llvm/IR/Operator.h"
+#include "llvm/IR/PatternMatch.h"
 #include "llvm/IR/Type.h"
 #include "llvm/IR/User.h"
 #include "llvm/IR/Value.h"
@@ -110,6 +111,7 @@
 #include <utility>
 
 using namespace llvm;
+using namespace PatternMatch;
 
 #define DEBUG_TYPE "isel"
 
@@ -1784,7 +1786,7 @@
     return selectBinaryOp(I, ISD::SUB);
   case Instruction::FSub:
     // FNeg is currently represented in LLVM IR as a special case of FSub.
-    if (BinaryOperator::isFNeg(I))
+    if (match(I, m_FNeg(m_Value())))
       return selectFNeg(I);
     return selectBinaryOp(I, ISD::FSUB);
   case Instruction::Mul:


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53650.170906.patch
Type: text/x-patch
Size: 1498 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181024/f3a7b445/attachment.bin>


More information about the llvm-commits mailing list